updated-device-name-implementation-for-backward-compatibility #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshirtman
reviewed
Jun 21, 2021
Member
tshirtman
left a comment
tshirtman
left a comment
There was a problem hiding this comment.
Does that affect the result? Or should it be the same? if so, any reason for the two different apis that would be important to consider?
For regarding the comment, i think it’s more important to put such things in the git commit message than in the documentation, as the documentation is more about how to use it than how it changed over time.
…id.os.Build for backward compatibility
tshirtman
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the previous
devicenameimplementation for android.Previous implementation was limited to API 17, updated the implementation so this this functionality works with API 1 as well.